search

Karm / mandrel-integration-tests

Integration tests for GraalVM and its Mandrel distribution. Runs Quarkus, Helidon and Micronaut applications and small targeted reproducers. The focus is solely on native-image utility and compilation of Java applications into native executables.
Apache License 2.0
5 stars 3 forks source link

Update whitelisted JFR log lines once more #242

Closed roberttoyonaga closed 6 months ago

roberttoyonaga commented 6 months ago

This is a follow up to: https://github.com/Karm/mandrel-integration-tests/pull/238

https://github.com/oracle/graal/pull/8037#event-11298904545 Has now been merged (internal PR), so I've adjusted the whitelisted lines.

This should prevent things form breaking when the latest JDK and GraalVM master are used. This PR replaces the old whitelisted lines. I'm not sure if that's the right thing to do (in case there is a test configuration that uses a development version that isn't the latest GraalVM master). I can add the old whitelisted lines back in if that's the case.

zakkak commented 6 months ago

I'm not sure if that's the right thing to do (in case there is a test configuration that uses a development version that isn't the latest GraalVM master). I can add the old whitelisted lines back in if that's the case.

I think you do the right thing by removing the old ones. Since they are not part of a release I believe we would like the test to fail if they show up.

jerboaa commented 6 months ago

I'd like to wait with merging this until we see a failure in CI.

zakkak commented 6 months ago

I'd like to wait with merging this until we see a failure in CI.

@jerboaa see https://github.com/Karm/mandrel-integration-tests/issues/240