search

Karm / mandrel-integration-tests

Integration tests for GraalVM and its Mandrel distribution. Runs Quarkus, Helidon and Micronaut applications and small targeted reproducers. The focus is solely on native-image utility and compilation of Java applications into native executables.
Apache License 2.0
5 stars 3 forks source link

Update quarkus version checks to adapt to new SNAPSHOT versions #247

Closed zakkak closed 5 months ago

zakkak commented 5 months ago

See https://github.com/quarkusio/quarkus/blob/3c8c772dda9ed99674c9d8a6cd9cb4635d1ce5a2/build-parent/pom.xml#L8 and https://github.com/quarkusio/quarkus/blob/bc0ca288d32ba2df212d8c4a2783c0bb21ca99a1/build-parent/pom.xml#L8

Relates to https://github.com/graalvm/mandrel/issues/501

zakkak commented 5 months ago

Consider adding some tests for QuarkusVersion comparisons so that this keeps working. Looks fine to me, though.

I extracted constant versions in constant fields in QuarkusVersion and also introduced tests for the class.

Thanks for the review @jerboaa

jerboaa commented 5 months ago

I extracted constant versions in constant fields in QuarkusVersion and also introduced tests for the class.

Very nice, thank you!