search

Karm / mandrel-integration-tests

Integration tests for GraalVM and its Mandrel distribution. Runs Quarkus, Helidon and Micronaut applications and small targeted reproducers. The focus is solely on native-image utility and compilation of Java applications into native executables.
Apache License 2.0
5 stars 3 forks source link

JFR tests are also built in a builder container now #58

Closed Karm closed 2 years ago

Karm commented 2 years ago

JFR tests were limited to locally installed Mandrel and some options tests were limited to version 21.3. This patch enabled JFR tests to be built in a builder container and lowers the min version to 21.2 since the patch for https://github.com/oracle/graal/issues/3638 was backported.

e.g.

Older 21.2, unpatched :x:

2021-10-01 14:17:34.848 INFO  [o.g.t.i.u.v.UsedVersion] (getVersion) The test suite runs with Mandrel version 21.2.0-0b3 in container.
2021-10-01 14:17:34.876 INFO  [o.g.t.i.JFRTest] (jfrOptionsSmoke) Testing app: JFR_OPTIONS_BUILDER_IMAGE
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 69.094 s <<< FAILURE! - in org.graalvm.tests.integration.JFRTest
[ERROR] jfrOptionsSmokeContainerTest{TestInfo}  Time elapsed: 39.958 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: 
Command `./target/timezones -XX:+FlightRecorder -XX:StartFlightRecording=maxsize=10k,filename=logs/flight-native.jfr -XX:FlightRecorderLogging=jfr' output did not match expected pattern `.* Started recording .* \{maxsize=10.0kB.*', it was: ./target/timezones -XX:+FlightRecorder -XX:StartFlightRecording=maxsize=10k,filename=logs/flight-native.jfr -XX:FlightRecorderLogging=jfr
Exception in thread "main" com.oracle.svm.core.util.UserError$UserException: Could not parse JFR argument 'maxsize=10k'. Expected a number.
    at com.oracle.svm.core.util.UserError.abort(UserError.java:68)
    at com.oracle.svm.jfr.JfrManager.parseLong(JfrManager.java:171)
    at com.oracle.svm.jfr.JfrManager.initRecording(JfrManager.java:107)
    at com.oracle.svm.jfr.JfrManager.setup(JfrManager.java:72)
    at com.oracle.svm.core.jdk.RuntimeSupport.executeHooks(RuntimeSupport.java:125)
    at com.oracle.svm.core.jdk.RuntimeSupport.executeStartupHooks(RuntimeSupport.java:75)
 ==> expected: <true> but was: <false>
    at org.graalvm.tests.integration.JFRTest.jfrOptionsSmoke(JFRTest.java:279)
    at org.graalvm.tests.integration.JFRTest.jfrOptionsSmokeContainerTest(JFRTest.java:150)

Patched 21.2 :heavy_check_mark:

2021-10-01 14:18:53.823 INFO  [o.g.t.i.u.v.UsedVersion] (getVersion) The test suite runs with Mandrel version 21.2.0.1-0b2 in container.
2021-10-01 14:18:53.851 INFO  [o.g.t.i.JFRTest] (jfrOptionsSmoke) Testing app: JFR_OPTIONS_BUILDER_IMAGE
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.914 s - in org.graalvm.tests.integration.JFRTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
Karm commented 2 years ago

Windows compatibility fixed.