search

Karm / mandrel-integration-tests

Integration tests for GraalVM and its Mandrel distribution. Runs Quarkus, Helidon and Micronaut applications and small targeted reproducers. The focus is solely on native-image utility and compilation of Java applications into native executables.
Apache License 2.0
5 stars 3 forks source link

CI yaml fixed after PR 60 changes, Whitelist regexp fix #61

Closed Karm closed 2 years ago

Karm commented 2 years ago

@zakkak 

 Error:    DebugSymbolsTest.debugSymbolsQuarkusContainer:256 build-and-run.log log should not contain error or warning lines that are not whitelisted. See /home/runner/work/mandrel-integration-tests/mandrel-integration-tests/ts/testsuite/target/archived-logs/org.graalvm.tests.integration.DebugSymbolsTest/debugSymbolsQuarkusContainer/build-and-run.log and check these offending lines: 
COPY failed: file not found in build context or excluded by .dockerignore: stat target/sources: file does not exist

Seems this is no longer valid? https://github.com/Karm/mandrel-integration-tests/blob/master/builder-image-apps/quarkus-vertx/src/main/docker/Dockerfile.native#L5

Looking at my old comment.... https://github.com/Karm/mandrel-integration-tests/blob/master/testsuite/src/it/java/org/graalvm/tests/integration/DebugSymbolsTest.java#L259

zakkak commented 2 years ago

@zakkak

 Error:    DebugSymbolsTest.debugSymbolsQuarkusContainer:256 build-and-run.log log should not contain error or warning lines that are not whitelisted. See /home/runner/work/mandrel-integration-tests/mandrel-integration-tests/ts/testsuite/target/archived-logs/org.graalvm.tests.integration.DebugSymbolsTest/debugSymbolsQuarkusContainer/build-and-run.log and check these offending lines: 
COPY failed: file not found in build context or excluded by .dockerignore: stat target/sources: file does not exist

Fixed in #62

Seems this is no longer valid? https://github.com/Karm/mandrel-integration-tests/blob/master/builder-image-apps/quarkus-vertx/src/main/docker/Dockerfile.native#L5

No, that seems OK

Karm commented 2 years ago

@zakkak So, there is still a difference we need to account for, probably by patching before test the same way as compatibility with Quarkus 1.7 was done.

Quarkus 2.2.3.Final + debug symbols + container is just fine.

Quarkus 2.4.0.Final in that scenario is missing a file I am trying to copy in that Dockerfile:

Error:    DebugSymbolsTest.debugSymbolsQuarkusContainer:256 build-and-run.log log should not contain error or warning lines that are not whitelisted. See /home/runner/work/mandrel-integration-tests/mandrel-integration-tests/ts/testsuite/target/archived-logs/org.graalvm.tests.integration.DebugSymbolsTest/debugSymbolsQuarkusContainer/build-and-run.log and check these offending lines: 
COPY failed: file not found in build context or excluded by .dockerignore: stat target/sources: file does not exist

/me running locally to nail it down, but apparently adding Quarkus 2.4.0.Final requires some migration work on TS.

Karm commented 2 years ago

Q 2.4.0.Final

$ find target/ -name sources
target/quarkus-native-image-source-jar/sources

Q 2.2.3.Final

$ find target/ -name sources
target/sources
zakkak commented 2 years ago

@Karm FYI https://github.com/quarkusio/quarkus/pull/20355 is marked for backport to Quarkus 2.2 so eventually it will be the same for both.

I guess our tests still need to cover this case till then though...

Karm commented 2 years ago

@zakkak Seems fine now. Ad perf results: I will examine them on a baremetal lab box.