Closed zakkak closed 2 years ago
Converting to draft. It looks like this PR is causing CI to run indefinitely. :eyes:
The issue causing the stall has been fixed.
The issue was that the new dumpAndLogProcess is blocking, so it can't be used to start a web-server in the background and then start a client to query it. To avoid complicating things, I just don't use dumpAndLogProcess in runCommand
, in those cases we just redirecto the output like we did before.
Another issue waiting to pop up was that dumpAndLogProcess didn't have a timeout, so if the underlying process was stuck the whole test would get stuck. This is now fixed by starting a single thread executor service for the dumping and logging with a timeout set.
@Karm this is now ready for you to re-review :)
ping @Karm
THX @zakkak , I will take a look. I haven't acked it before as I was afraid of what the change does on Jenkins. Gimme a day.
Pros:
Cons: