Open zakkak opened 2 years ago
+1
Any way you could contribute such a test upstream?
Any way you could contribute such a test upstream?
Sure, especially if you can point us to some existing upstream test checking the compilation output.
Sure, especially if you can point us to some existing upstream test checking the compilation output.
I'm afraid we don't have any tests for the new output (yet).
I'm afraid we don't have any tests for the new output (yet).
@fniephaus I meant "any" test checking the compilation output, e.g., it could be some testing checking to see if a warning was thrown etc. If there is no such tests already in place we should discuss this upstream to see how we should implement it (e.g. let mx
generate temp files and grep them? Create junit tests that run native-image and check the output? etc.).
I'm afraid I haven't seen any such tests. I don't think it makes sense to unit-test the reporter but I also have no idea how to check all possible or at least most error cases that can happen in Native Image. Of course, we could start with something simple. I just haven't had the chance to look into it.
With the new native-image output Peak RSS is also reported.
We should implement a test that would ensure Peak RSS is indeed reported (see https://github.com/graalvm/mandrel-packaging/issues/211)