search

Karm / mandrel-integration-tests

Integration tests for GraalVM and its Mandrel distribution. Runs Quarkus, Helidon and Micronaut applications and small targeted reproducers. The focus is solely on native-image utility and compilation of Java applications into native executables.
Apache License 2.0
5 stars 3 forks source link

Create test to ensure Peak RSS is being reported #72

Open zakkak opened 2 years ago

zakkak commented 2 years ago

With the new native-image output Peak RSS is also reported.

We should implement a test that would ensure Peak RSS is indeed reported (see https://github.com/graalvm/mandrel-packaging/issues/211)

jerboaa commented 2 years ago

+1

fniephaus commented 2 years ago

Any way you could contribute such a test upstream?

zakkak commented 2 years ago

Any way you could contribute such a test upstream?

Sure, especially if you can point us to some existing upstream test checking the compilation output.

fniephaus commented 2 years ago

Sure, especially if you can point us to some existing upstream test checking the compilation output.

I'm afraid we don't have any tests for the new output (yet).

zakkak commented 2 years ago

I'm afraid we don't have any tests for the new output (yet).

@fniephaus I meant "any" test checking the compilation output, e.g., it could be some testing checking to see if a warning was thrown etc. If there is no such tests already in place we should discuss this upstream to see how we should implement it (e.g. let mx generate temp files and grep them? Create junit tests that run native-image and check the output? etc.).

fniephaus commented 2 years ago

I'm afraid I haven't seen any such tests. I don't think it makes sense to unit-test the reporter but I also have no idea how to check all possible or at least most error cases that can happen in Native Image. Of course, we could start with something simple. I just haven't had the chance to look into it.