Karmabunny / sprout3

SproutCMS: content management and framework
http://getsproutcms.com
GNU General Public License v2.0
24 stars 3 forks source link

Feat/needs seo merge #72

Closed jamiemonksuk closed 1 year ago

jamiemonksuk commented 1 year ago

This merges the (already reviewed) custom head tags branch, applies some small tweaks based on review, then builds on that by extending Needs a little, and pushing SocialMeta display behaviour over into Needs.

I've tested this with a local patch on the TheyStay repo and it seems to work nicely

jamiemonksuk commented 1 year ago

Just a note, you might want to review this commit by commit after the initial merge, which remains unchanged from the previous review at that point

jamiemonksuk commented 1 year ago

homepage_custom_tags

Maybe for now we pull them out, then look at it as a new piece?

jamiemonksuk commented 1 year ago

I split them out into a new helper as proposed, seems cleaner too

jamiemonksuk commented 1 year ago

@gwillz I rejigged it to be table agnostic as per @aitken85 suggestion :)