search

Karmalakas / grav-plugin-photoswipe

Add Photoswipe gallery to your pages
MIT License
8 stars 1 forks source link

Known issue into README #12

Closed hughbris closed 1 year ago

hughbris commented 1 year ago

I got caught out by this in a production environment and it took me a long time to find the closed issue which mention it (that is my fault!). A note in the README might help someone else find this important gotcha sooner.

hughbris commented 1 year ago

I added a new commit. I'm not sure how that gets integrated now.

Karmalakas commented 1 year ago

I decided to merge it without creating a new release. When I do some update, it'll get in the release. But I noticed only after merge the bold disappeared because of missing ** in the beginning of a note 😅 If you don't mind creating another PR to fix this, I would be grateful 🙂 But it's not that important to do this ASAP IMO

hughbris commented 1 year ago

I decided to merge it without creating a new release. When I do some update, it'll get in the release.

Don't worry, I wouldn't create a new release for this either. I am pretty sure at least 90% of people who need to see this will be reading the latest version here on Github.

If you don't mind creating another PR to fix this, I would be grateful slightly_smiling_face

Will do, sorry for the blooper. I don't have a handy markdown previewer and I probably should!