Item adjust - Githubissues

Karmel0x / LeagueEmulatorJS

League of Legends game server emulator (IN DEVELOPMENT)

GNU General Public License v3.0

26 stars 8 forks source link

Item adjust #3

Closed DantestyleXD closed 3 years ago

DantestyleXD commented 3 years ago

Hello!

This PR contain:

ItemList order by a decrescend IDs order;
Now you can manage Items that can be buy with some "build items" (see Infinity Edge with a B.F. Sword)
Fixed the buy logic to subtract player's gold after confirm that conditions are all satisfy ( gold available, slot available )

Karmel0x commented 3 years ago

Thanks for first Pull Request.

~~As it's early stage of project I am trying to make commits with 200+ additions.~~ Would be great if you could make some more stuff here, I will Squash and merge this PR. Or let me know so I will just merge it after corrections to my review.

DantestyleXD commented 3 years ago

Let me know if I have something else to edit (I probably edit all about your reviews) In anycase, I will look for something else to insert/improve 👍

Karmel0x commented 3 years ago

Need to also resolve problem in https://github.com/Karmel0x/LeagueEmulatorJS/pull/3#discussion_r703466814

The rest is fine I guess ~~but as I said, I don't want to make small commits~~ so I will just leave this Pull Request open for now and I will commit here when I will be doing Inventory stuff, then I will Squash this PR to single commit and merge to repository. If you want to do some other things just open new PR, or use this one for related things (Inventory).

DantestyleXD commented 3 years ago

[x] Separate buildFromItems function with another function
[ ] WIP: Mass import and setting for ItemList.js

For the last point, just look it (I have a lot of values to insert that I will insert)