search

KarolTrzeszczkowski / Inter-Wallet-Transfer-EC-plugin

A plugin, that sends your coins to another wallet one by one, every time to a fresh address.
GNU General Public License v3.0
8 stars 8 forks source link

Sending funds to Multisig Wallet #17

Open qntoine opened 4 years ago

qntoine commented 4 years ago

Hi,

I tried to use the plugin to transfer funds to a multisig wallet (1-of-2) as a test. The wallet was generated by Copay but could be imported into Electron Cash without an issue (past transactions were correctly displayed by Electron Cash so the derivation path must be correct). The Master Public Key displayed in both Copay and Electron Cash is identical.

However, when inputting the Master Public Key in the Inter Wallet Transfer window, transfers were initialized correctly but never reached the target wallet. On closer inspection, there seems to be an issue with the addresses generated. I am not an expert but the addresses generated start with a 'q' (P2PKH) instead of 'p' (P2SH, which is the address type used by the target wallet).

Sorry maybe I missed some parameter, but could you check if that error is reproducible and fixable?

Thank you,

KarolTrzeszczkowski commented 4 years ago

Oh hell, I never predicted someone will do this thing. To generate 1-of-2 multisig addresses you need both xpub keys. Your coins should be accessible if you generate a standard walllet from the seed corresponding to the xpub or from xpriv corresponding to this xpub.

Sorry I haven't made this obvious in ux. Ping me if you were able to access the money.

qntoine commented 4 years ago

Hello,

Thank you for your swift reply.

No problem, I will try recovering the coins later today. I just didn't know multisig wallets worked differently since each user has their own xpub anyway; so I learnt something along the way, thanks!

I don't know whether there is much demand for that, but it would be great to add a function to send funds to multisig wallets as well in the future (unless there is already a way to input several xpub keys now but I don't see how).

Best regards,