search

Karql / elastalert2-server

ElastAlert that exposes REST API's for manipulating rules and alerts
MIT License
59 stars 22 forks source link

Remove raven-node #59

Closed nsano-rururu closed 2 years ago

nsano-rururu commented 2 years ago

raven-node → @sentry/node

https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md#400

4.0.0 This is the release of our new SDKs, @sentry/browser, @sentry/node. While there are too many changes to list for this release, we will keep a consistent changelog for upcoming new releases. raven-js (our legacy JavaScript/Browser SDK) and raven (our legacy Node.js SDK) will still reside in this repo, but they will receive their own changelog.

We generally guide people to use our new SDKs from this point onward. The migration should be straightforward if you were only using the basic features of our previous SDKs.

raven-js and raven will both still receive bugfixes but all the new features implemented will only work in the new SDKs. The new SDKs are completely written in TypeScript, which means all functions, classes and properties are typed.

Migrating from raven-js to @sentry/browser https://github.com/getsentry/sentry-javascript/blob/master/MIGRATION.md#migrating-from-raven-js-to-sentrybrowser

Karql commented 2 years ago

To be honest, I didn't even know there was such a library 😅

Do you use this functionality? It was never even documented.

I will remove it.

nsano-rururu commented 2 years ago

I also noticed recently. I thought there was a warning with npm install, but when I checked it properly, it looked like this.

nsano-rururu commented 2 years ago

Implement Sentry logging https://github.com/bitsensor/elastalert/commit/d8a9d9fdcbd4e17ac431bc280eebd6e0fbf744e6

nsano-rururu commented 2 years ago

You need to remove raven-node and fix the code used by raven-node https://github.com/Karql/elastalert2-server/blob/master/src/index.ts#L10

Karql commented 2 years ago

Removed