search

KarrLab / datanator_frontend

Graphical web-based interface for the Datanator toolkit for discovering data for modeling cells
https://datanator.info
MIT License
1 stars 1 forks source link

Can the requirement `package.json` be removed? #202

Closed jonrkarr closed 4 years ago

jonrkarr commented 4 years ago

This is the source of the build failure. It doesn't look like we need this. Can it be removed (i.e. npm uninstall package.json)?

If it is necessary, the build can be fixed simply by adding package.json to the ignores section in .depcheckrc.yml.

lzy7071 commented 4 years ago

To which requirement are you referring?

jonrkarr commented 4 years ago

Line 82 in package.json:

"package.json": "^2.0.1",

This is to lookup package metadata from NPM. I suspect this was unintentionally added at 085758f2cd9627d110ab05240df8ce827e462d9a.

lzy7071 commented 4 years ago

That was, indeed, unintentionally added. Although I don't know how it got added. I tried running a local production server with npm install package.json Perhaps that was it? But "package.json": "^2.0.1", is definitely not needed.

jonrkarr commented 4 years ago

I removed this.

The argument to npm install is either (a) a name of a package in NPM or (b) a path to a directory which contains a package.json file.