KarrLab / datanator_frontend

Graphical web-based interface for the Datanator toolkit for discovering data for modeling cells
https://datanator.info
MIT License
1 stars 1 forks source link

Yosef dev2 #205

Closed yosefdroth closed 4 years ago

yosefdroth commented 4 years ago

The major additions so far: 1) Seperated the protein metadata from AbundanceTable so that AbundanceTable does not need the list of uniprot id's from the metadata. 2) Added more metadata to the protein page 3) Added tooltips to Taxonomic Similarity and Chemical Similarity

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 946


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/scenes/BiochemicalEntityDetails/DataTable/DataTable.js 15 16 93.75%
src/scenes/BiochemicalEntityDetails/Protein/AbundanceDataTable.js 18 19 94.74%
src/scenes/BiochemicalEntityDetails/Reaction/RateConstantsDataTable.js 10 11 90.91%
src/scenes/BiochemicalEntityDetails/TaxonomyFilter.js 12 13 92.31%
src/scenes/BiochemicalEntityDetails/Protein/MetadataSection.js 20 22 90.91%
src/scenes/BiochemicalEntityDetails/LoadExternalData.js 11 14 78.57%
<!-- Total: 91 100 91.0% -->
Totals Coverage Status
Change from base Build 920: -0.5%
Covered Lines: 1203
Relevant Lines: 1270

💛 - Coveralls
yosefdroth commented 4 years ago

I have made those changes. I also updated taxonomy in the metabolites page.

There is currently one integration test which is failing -- TaxonomyFilter. I made some changes to TaxonomyFilter, so this makes sense, but I cannot figure out why the test is failing. The filter appears to work normally in the actualy page. Do you think you could take a look?