KarrLab / datanator_frontend

Graphical web-based interface for the Datanator toolkit for discovering data for modeling cells
https://datanator.info
MIT License
1 stars 1 forks source link

Change reaction identifiers to not use spaces #251

Closed jonrkarr closed 4 years ago

jonrkarr commented 4 years ago

To start advertising Datantor, I submitted it to a few registries of biology resources. One of these is the Identifiers.org database of namespaces. They accepted our metabolite and gene namespaces. To accept our reaction namespace, we need to disallow spaces.

Two alternative to {comma-separated-list-of-substrates-names}-->{comma-separated-list-of-product-names}:

This is not critical. Although our reaction namespace wasn't accepted, Datanator will be findable through Identifiers.org.

lzy7071 commented 4 years ago

To start advertising Datantor, I submitted it to a few registries of biology resources. One of these is the Identifiers.org database of namespaces. They accepted our metabolite and gene namespaces. To accept our reaction namespace, we need to disallow spaces.

Two alternative to {comma-separated-list-of-substrates-names}-->{comma-separated-list-of-product-names}:

  • {comma-separated-list-of-substrate-inchikeys}-->{comma-separated-list-of-product-inchikeys}
  • Assign a unique id to each reaction

This is not critical. Although our reaction namespace wasn't accepted, Datanator will be findable through Identifiers.org.

I think the first bullet point is a good idea and can be easily implemented.

The second bullet point can help avoid a long URL.

jonrkarr commented 4 years ago

I've implemented this into the frontend.

There's just one thing left. The kinlaw_by_rxn endpoint needs to support the taxon_distance parameter. See karrlab/datanator_rest_api#84.

lzy7071 commented 4 years ago

I've implemented this into the frontend.

There's just one thing left. The kinlaw_by_rxn endpoint needs to support the taxon_distance parameter. See KarrLab/datanator_rest_api#84.

I just added the requested support. See https://github.com/KarrLab/datanator_rest_api/issues/84#issuecomment-632910930