Fixing circleci errors for master branch

KarrLab / datanator_frontend

Graphical web-based interface for the Datanator toolkit for discovering data for modeling cells

https://datanator.info

MIT License

1 stars 1 forks source link

Fixing circleci errors for master branch #298

Closed lzy7071 closed 4 years ago

lzy7071 commented 4 years ago

How does one go about fixing the errors shown here? The reason the errors needed fixing is because:

Netlify build was stopped so in order for updates to master to get deployed, Auto Publishing had to be turned on at Netlify.
Production builds should only be deployed after tests are passed.
If the errors persist, no new production builds will be deployed.

jonrkarr commented 4 years ago

One error is due to changes the I made to address Wolf's feedback. The second is due to timing of the response of the REST API. Both should be fixed.

lzy7071 commented 4 years ago

It seems build-third-party-license-report is still causing an issue here

jonrkarr commented 4 years ago

Its the dependency checking that failed. This should be fixed now. This is checking (a) all of the dependencies listed in package.json are used (i.e., imported somewhere) and (b) package.json lists all of the dependencies (everything that is imported at least once). For the most part, the dev dependencies need to be ignored by adding them to .depcheckrc.yml because they aren't imported.

FYI, the end of the testing step prints out a summary of the failures, e.g.

Build failed:
- Test for missing and unused dependencies failed

lzy7071 commented 4 years ago

Great. Thank you for the information. I didn't know how to fix that particular dependency-related error. I've also been trying to figure out how to fix some cypress errors from integration tests. They seem to come and go.