search

KarrLab / datanator_rest_api

A OAS3 compliant REST API for the Datanator integrated database
MIT License
0 stars 3 forks source link

How can I retrieve reactions associated with an OrthoDB group? #124

Closed jonrkarr closed 4 years ago

jonrkarr commented 4 years ago

Is the URL below the intended pattern? Can you point me to an example so I can make sure the frontend is updated correctly?

proteins/related/related_reactions_by_kegg/?ko=567019at2

lzy7071 commented 4 years ago

Yes. This should be fixed in five minutes.

lzy7071 commented 4 years ago

https://github.com/KarrLab/datanator_query_python/commit/4a92df37467a5764213fa36162e327ef7e65b6d8 should fix the issue.

jonrkarr commented 4 years ago

Can you point me to an example URL which returns data so I can make sure the frontend is updated correctly?

lzy7071 commented 4 years ago

Can you point me to an example URL which returns data so I can make sure the frontend is updated correctly?

Sorry for the delay. I was fixing other issues. It seems circle downstream trigger only tests for master branch so the testapi branch of datanator_rest_api wasn't tested and deployed. I just manually triggered the tests.

jonrkarr commented 4 years ago

Yes, the downstream tests are only setup to trigger tests on the master branch of the downstream package.

lzy7071 commented 4 years ago

This is working now https://testapi.datanator.info/proteins/related/related_reactions_by_kegg/?ko=643917at2 The reason 567019at2 didn't return any results is that we have two entries of proteins that fall under 567019at2: P07999 and P13650, neither of which catalyzes or is a part of an enzyme that catalyzes reactions recorded in SABIO-RK.

jonrkarr commented 4 years ago

Looks good.

Yes, I know not all genes catalyze reactions. Thanks for pointing to an example.