KarrLab / datanator_rest_api

A OAS3 compliant REST API for the Datanator integrated database
MIT License
0 stars 3 forks source link

Gene search results should be grouped by OrthoDB id #129

Closed jonrkarr closed 3 years ago

jonrkarr commented 3 years ago

In the example below, "P00367" appears as a result twice. "P00367" should only appear as a member of an OrthoDB group, and not appear as a separate result just for this UniProt id. I could filter this in the frontend, but this would result in cases where only 9 search results appear instead of the expected 10.

https://testapi.datanator.info/ftx/text_search/gene_ranked_by_ko/?query_message=P00367&from_=0&size=10&fields=orthodb_id&fields=orthodb_name&fields=gene_name&fields=gene_name_alt&fields=gene_name_orf&fields=gene_name_oln&fields=entrez_id&fields=protein_name&fields=entry_name&fields=uniprot_id&fields=ec_number

I can't tell exactly what the issue is. Some possibilities

jonrkarr commented 3 years ago

The other open issues are more important to address than this one

lzy7071 commented 3 years ago

Feed new docs in rna_halflife collection with orthodb_id and orthodb_name to Elasticsearch.

jonrkarr commented 3 years ago

This sounds like a note for you to help you keep track of your work. If this is intended for me, I'm not sure how to follow your notes to revise the frontend.

lzy7071 commented 3 years ago

This sounds like a note for you to help you keep track of your work. If this is intended for me, I'm not sure how to follow your notes to revise the frontend.

It's for myself.

lzy7071 commented 3 years ago

https://testapi.datanator.info/ftx/text_search/gene_ranked_by_ko/?query_message=P00367&from_=0&size=10&fields=orthodb_id&fields=orthodb_name&fields=gene_name&fields=gene_name_alt&fields=gene_name_orf&fields=gene_name_oln&fields=entrez_id&fields=protein_name&fields=entry_name&fields=uniprot_id&fields=ec_number is fixed.

jonrkarr commented 3 years ago

Thanks!