KarrLab / obj_tables

Tools for creating and reusing high-quality spreadsheets
https://objtables.org
MIT License
8 stars 2 forks source link

Uncontrolled columns - import and export #156

Open liebermeister opened 4 years ago

liebermeister commented 4 years ago

Hi Jonathan,

I'm sorry for bringing this up again, it's about the "uncontrolled" columns (those that do not start with a "!").

If I remember correctly, the parser does not ignore them, but reads them and attaches their content to the data objects as "comments" or extra information. For my own intended usage of ObjTables (for the results of Enzyme Cost Minimisation) it would be important that this information can also be exported again, such that after a round of import and export, the "uncontrolled" columns would still exist. I think this is not the case right now.

Could you implement this?

Thank you!!

Best, Wolf

jonrkarr commented 4 years ago

ObjTables ignores this information. Similarly, ObjTables ignores additional worksheets. There isn't a great way to deal with this content for a couple of reasons

Extra columns could be parsed into a attribute, e.g. Model._extra_attrs. To deal with the potential issue that column headings could be empty or repeated, it would have to be a list of tuples of column headings and values of each row. Users of the Python package could easily misuse this. The spreadsheet output would have to try to infer the column headings.

We would have to hack a mechanism to deal with extra workshseets.

In both cases, ObjTables would not reproduce any formatting. This is somewhat intentional so that ObjTables produces "canonically" formatted spreadsheets.