search

KarrLab / wc_sim

A multi-algorithmic simulator for whole-cell models
MIT License
6 stars 2 forks source link

downstream dependence + relation to old_wc_sim #15

Closed szb37 closed 5 years ago

szb37 commented 6 years ago

Please configure the mycoplasma repo as a downstream dependency, so that when changes are made here that repo is also tested on circle. Currently that is not the case, which can complicate seeing what broke the mycoplasma repo

Related to this issue is that I am not sure if there is any functionality in the old_wc_sim folder (within the mycoplasma repo) or if it has been completely re-implemented in this repo by now. If that is the case, probably we should delete the old_wc_sim for clarity

jonrkarr commented 6 years ago

old_wc_sim is not a separate repo. This hasn't changed.

mycoplasma_pneumoniae is already a downstream dependency of wc_sim.

The problem is not that the downstream repo isn't configured, but that the mycoplasma_pneumoniae tests (test_full_model) are being skipped because the mycoplasma_pneumoniae has been broken for a long time.

On Wed, May 9, 2018 at 11:29 AM balazs1987 notifications@github.com wrote:

Please configure the mycoplasma repo as a downstream dependency, so that when changes are made here that repo is also tested on circle. Currently that is not the case, which can complicate seeing what broke the mycoplasma repo

Related to this issue is that I am not sure if there is any functionality in the old_wc_sim folder (within the mycoplasma repo) or if it has been completely re-implemented in this repo by now. If that is the case, probably we should delete the old_wc_sim for clarity

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/KarrLab/wc_sim/issues/15, or mute the thread https://github.com/notifications/unsubscribe-auth/ACt2KSaxipCGNlCFAEomxnRuNn67nuL2ks5twwtygaJpZM4T4h4A .

szb37 commented 6 years ago

So if a push is made to wc_sim, then test_full_model is triggered, but not the other test files in mycoplasma, right? If that is the case, test_main should also be triggered as some tests there also use wc_sim.

jonrkarr commented 6 years ago

All of the tests are run with each build.

The CircleCI dashboard displays the lab logo next to the tests that are triggered from upstream dependencies.

The "Build Parameters" tab within the build pages (e.g. https://circleci.com/gh/KarrLab/mycoplasma_pneumoniae/544#build-parameters/containers/0) indicates which upstream repo triggered the build. For builds triggered by upstream repos, the build pages also say "Triggered by: API".

On Wed, May 9, 2018 at 11:50 AM balazs1987 notifications@github.com wrote:

So if a push is made to wc_sim, then test_full_model is triggered, but not the other test files in mycoplasma, right? If that is the case, test_main should also be triggered as some tests there also use wc_sim.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/KarrLab/wc_sim/issues/15#issuecomment-387785780, or mute the thread https://github.com/notifications/unsubscribe-auth/ACt2KRqPozuul7fQkxblT38nPNldv2RSks5twxBXgaJpZM4T4h4A .

artgoldberg commented 5 years ago

No longer needed, I believe.