Closed jonrkarr closed 4 years ago
Done:
DynamicCompartment.__init__
ModelUtilities.concentration_to_molecules
Todo:
MultialgorithmSimulation.__init__
in which the compartment volumes and species counts are initializedModelUtilities.concentration_to_molecules
doesn't clearly indicate its role in the initialization of species counts conditioned on initial compartment volumes.initialization done refactoring and renaming to be considered
WRT "It would best to refactor the initialization of simulation state so that it is separate from the construction of simulation objects. This will allow the establishment of the object graph in the construction of the objects and then initialization of simulation state using the object graph", I see your point.
However, in my implementation I addressed this issue by partially initializing
some dynamical objects, like DynamicCompartment
s and the species populations accessed by DynamicSpecies
s, before creating the remaining dynamic objects and preparing them for simulation. Thus this refactoring isn't urgent now and I'm moving it to a new issue.