Peer review 2

[aadnw]

Setting up and testing the app:

• Add a mention to the beginning that the root directory for the app, where everything should be set up (create database, .env, flask run, etc.) is /db-and-web-dev/sovellus/ , I think that for many the assumption is that the root directory is the first directory!

• A few error messages I faced with the database:

  1. when adding schema.sql to the database I got error message: ERROR: relation "users" does not exist LINE 1: INSERT INTO users (username, password, role, last_online) VA...
  2. when trying login as an admin by following "admin creation.txt" I got error message: INSERT INTO users (username, password, role, last_online) VALUES ('admin', 'scrypt:32768:8:1$4qWkuzowHTmuql0z$487a07924cda4545a5c38fed3f2381fd06c5a87e9d147828abd83db59525eba91da3555c4e4734912f1e2db6a3fa9efc793a295a37a6cf009eeb3c74b3ce10de','admin', CURRENT_TIMESTAMP); ERROR: column "last_online" of relation "users" does not exist LINE 1: INSERT INTO users (username, password, role, last_online) VA...

• The app is working as a user and I didn't face any difficulties. Everything works smoothly and it's clear for the user what to do and where in the app. Maybe adding some colours and touches to the appearance of the app will make it perfect :)

Code:

• Your code is very clear and pleasant to look at
• Comments and notes on different functions etc. is really helping to understand what is happening
• for me personally your database seems a bit confusing but it's working (not the admin part for testing though) so that's not a problem

Conclusion:

• Your project seems to be on good track and with some finishing touches it will be ready probably soon :)
• Also the idea for this project is great :)

[Karri6]

Thanks for the feedback! I updated the sql command in the admin creation txt file. If you have time and energy could you test if the admin user works on your side now? No worries if you can't do this right now, I can fix it on my own too later! Thank you!

[aadnw]

Now I get this error message:

ERROR: invalid input syntax for type integer: "admin" LINE 2: ...2f1e2db6a3fa9efc793a295a37a6cf009eeb3c74b3ce10de', 'admin'); ^

[Karri6]

Okay thank you, what OS are you using?

I tested the shcema.sql by creating a new db following the instructions. I then used the ready sql command and successfully created a new entry to the table without error messages. (Windows 11)

Will try to find a friend with a computer that runs a different OS to see if there is more to add to the instructions.