search

KarsMulder / evsieve

A utility for mapping events from Linux event devices.
GNU General Public License v2.0
199 stars 11 forks source link

persist mode exit #13

Closed nadenislamarre closed 2 years ago

nadenislamarre commented 2 years ago

Signed-off-by: Nicolas Adenis-Lamarre nicolas.adenis.lamarre@gmail.com

KarsMulder commented 2 years ago

This pull request adds a --input persist=exit clause, which will make evsieve exit whenever any input device with that clause specified disconnects. This differs from the default behaviour, where evsieve only exits after all input devices have been disconnected.

I don't have problems with adding this feature and the submitted implementation looks correct.

That said, I do feel a bit queasy about turning the source code's copyright status into a "jointly owned copyrighted work" over a contribution of 16 lines. Sorry if this is a bit rude after you went through the effort of reading the source code and implementing this feature, but would you mind if I tried to reimplement this feature myself?

nadenislamarre commented 2 years ago

do as you prefer. (even if i don't really understand the reason to open pr then) this is to use into https://github.com/batocera-linux/batocera.linux/tree/master/package/batocera/utils/evsieve i let you close this pr. thanks for your work, it will be very helpfull for arcade joysticks i guess.

KarsMulder commented 2 years ago

Sorry again. I just tend to worry more about legal technicalities than most people do.

Anyway, a persist=exit feature has been added in commit a2bcb4ed0ced2aa82ea384966257760ba186917a.