search

Karsten1987 / confbot_robot

workspace comprising demo packages for our roscon2018 talk
Apache License 2.0
10 stars 8 forks source link

enable linters #21

Closed mikaelarguedas closed 5 years ago

mikaelarguedas commented 5 years ago

Enable lint_cmake and xmllint linters, addresses https://github.com/Karsten1987/roscon2018/pull/20#discussion_r271675498

Karsten1987 commented 5 years ago

What exactly is happening here?

before the following tests were executed:

100% tests passed, 0 tests failed out of 35

Label Time Summary:
cppcheck      =  11.55 sec*proc (11 tests)
cpplint       =  17.79 sec*proc (11 tests)
flake8        =   1.67 sec*proc (1 test)
linter        =  44.28 sec*proc (35 tests)
pep257        =   1.05 sec*proc (1 test)
uncrustify    =  12.22 sec*proc (11 tests)

Now only a few are running:

100% tests passed, 0 tests failed out of 2

Label Time Summary:
lint_cmake    =   0.91 sec*proc (1 test)
linter        =   1.98 sec*proc (2 tests)
xmllint       =   1.06 sec*proc (1 test)
mikaelarguedas commented 5 years ago

With ADD_LINTER_TESTS, linters were ran on the generated code. This is use to catch issues in the message generators, but doesn't need to be ran on the leaf packages. But it did not rune linters on the code in this package.

This PR removed the linting of the generated code (it takes significant testing time and reveal issues unrelated to this package) and enable the linters for the code in this package (namely linting the package.xml and the CMake code)