Karsten1987 / confbot_robot

workspace comprising demo packages for our roscon2018 talk
Apache License 2.0
10 stars 8 forks source link

add legacy ros1 bag file #38

Closed Karsten1987 closed 5 years ago

Karsten1987 commented 5 years ago

~Needs https://github.com/ros2/rosbag2_bag_v2/pull/3~

Signed-off-by: osrf karsten@openrobotics.org

Karsten1987 commented 5 years ago

This adds two demo bags in the resource folder which can be used for demo purposes. There is a ros2 bag file which contains plain ros2 recorded twist messages. The second bag file is a ros1 legacy bag file and can be replayed via the bridge and the rosbag2 v2 plugin. The tutorial markdown is enhanced to give some more insights on how to use these bags.

mikaelarguedas commented 5 years ago

I tried replaying the ROS1 and ROS2 bags and it worked for me :+1:

Steps I went through to get it running:

We can aggregate all the debs to install in https://github.com/Karsten1987/roscon2018/issues/40? Have you considered a metapackage for all the "default" rosbag2 packages? Will rosbag2_bag_v2 be released in the next Dashing sync? or will users need to build it themselves? Should the bag files be installed ? (I dont believe so but just to make sure)

mikaelarguedas commented 5 years ago

Works for me, I'm going to merge this and iterate on the doc once this and https://github.com/Karsten1987/roscon2018/pull/19 are merged