issues
search
KarthickNarayana
/
toy_robot
0
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Where compound conditionals exist, test all cases independently
#23
scepticalcat
opened
3 years ago
1
Unnecessary mocking
#22
scepticalcat
opened
3 years ago
0
Exposing methods purely for testing purposes
#21
scepticalcat
opened
3 years ago
0
Assertions based on "impossible" values
#20
scepticalcat
opened
3 years ago
1
Use random data
#19
scepticalcat
opened
3 years ago
1
Consider end users
#18
scepticalcat
opened
3 years ago
1
Always run specs in random order
#17
scepticalcat
opened
3 years ago
1
Invalid horizontal positions will be ignored and method will return true as long as the vertical position is valid
#16
scepticalcat
opened
3 years ago
1
Avoid abbreviating variable names
#15
scepticalcat
opened
3 years ago
0
This makes the failure case of `Command.process` redundant
#14
scepticalcat
opened
3 years ago
1
Reliance on unset `@robot` instance var
#13
scepticalcat
opened
3 years ago
0
Overlap with existing methods
#12
scepticalcat
opened
3 years ago
0
Responsibility boundaries
#11
scepticalcat
opened
3 years ago
1
Camel case vs snake case
#10
scepticalcat
opened
3 years ago
1
`attr_reader` vs. `attr_accessor`
#9
scepticalcat
opened
3 years ago
1
Public vs. Private
#8
scepticalcat
opened
3 years ago
1
Redefining the namespaced `Error` class?
#7
scepticalcat
opened
3 years ago
1
Case statement limits maintainability
#6
scepticalcat
opened
3 years ago
1
Public exposure of what should be a private accessor
#5
scepticalcat
opened
3 years ago
1
Table as a dependency is injected, but the robot is not
#4
scepticalcat
opened
3 years ago
1
The application doesn't raise any exceptions, so the base error class is redundant
#3
scepticalcat
opened
3 years ago
1
Inline loading of commands would be cleaner
#2
scepticalcat
opened
3 years ago
1
Bootstrapping of repo through Bundler is an odd choice
#1
scepticalcat
opened
3 years ago
0