KarthikRIyer / swiftplot

Swift library for Data Visualization :bar_chart:
Apache License 2.0
398 stars 36 forks source link

Add Anchor Support for Annotations #100

Closed WilliamHYZhang closed 4 years ago

WilliamHYZhang commented 4 years ago

Introducing the newest feature for annotations, the ability to anchor them to anything! This idea started as just to anchor text annotations, but with the help of some nifty tricks we can expand this significantly. Here's an overview of what I did in this PR:

So what does this mean for the future of annotations in SwiftPlot?

Anyways, hope you guys like it. I'm definitely open to any suggestions for improvements or new ideas. Feel free to check it out.

William

WilliamHYZhang commented 4 years ago

Oooof. PR build is failing... I'll look into it.

WilliamHYZhang commented 4 years ago

Fixed, @karwa when this is merged may you rerun quartz tests when you have time? No hurry.

WilliamHYZhang commented 4 years ago

@KarthikRIyer resolved merge conflicts

WilliamHYZhang commented 4 years ago

@KarthikRIyer should be good to go.

KarthikRIyer commented 4 years ago

Looks good @WilliamHYZhang. Good job!