KarthikRIyer / swiftplot

Swift library for Data Visualization :bar_chart:
Apache License 2.0
400 stars 39 forks source link

Create SwiftPlot_Ubuntu.yml #114

Closed KarthikRIyer closed 4 years ago

KarthikRIyer commented 4 years ago

I've added a new Github Action that builds SwiftPlot on Ubuntu. Please take a look and let me know of any required changes.

@karwa @odmir

karwa commented 4 years ago

Looks good! It's really nice to have CI validate both platforms. I'm also keeping an eye on Windows support; at least one project is doing it, but it's not straightforward.

One thing that would be good is to upload the generated files, like we do on the Mac. GitHub doesn't have a usage limit for it (limits are all about concurrent jobs), so why not?

KarthikRIyer commented 4 years ago

@karwa done.

Is there support for SPM in Windows?

karwa commented 4 years ago

@KarthikRIyer I honestly don't know.

KarthikRIyer commented 4 years ago

There's this: https://github.com/SwiftForWindows/SwiftForWindows But it doesn't provide SPM. To build we have to use a build.json file instead of Package.swift. So I think it will be difficult to get it to work with windows.

karwa commented 4 years ago

I think that project is quite old; that's not the latest state of Swift on Windows.

This document in the official repo seems to suggest that SPM is supported.