Make Plot.drawGraph(Renderer) public, faster base64 encoding

KarthikRIyer / swiftplot

Swift library for Data Visualization :bar_chart:

Apache License 2.0

401 stars 39 forks source link

Make Plot.drawGraph(Renderer) public, faster base64 encoding #54

Closed karwa closed 4 years ago

karwa commented 4 years ago

Some small tweaks:

Make Plot.drawGraph(Renderer) public
Faster base64 encoding using a non-copying Data object
Added a rudimentary test for base64 encoding

KarthikRIyer commented 4 years ago

The new test hasn't yet been added to __allTests() yet, so it doesn't run when using swift test. The same with the test for SubPlots.

karwa commented 4 years ago

@KarthikRIyer done. SwiftPM is actually able to discover tests if you give it the --enable-test-discovery flag, but for some reason that's not the default ¯_(ツ)_/¯

KarthikRIyer commented 4 years ago

Thanks @karwa . There seems to be some talk about making it default here but nothing conclusive.

Merging.