Closed GoogleCodeExporter closed 8 years ago
Hi,
could you please review my coding. From my perspective, the binding is ready.
It is allready testet and used successfully by me and 4 other people.
Sample config files are included in the attachment.
Waiting for your comments
Holger
Original comment by holger.h...@gmail.com
on 12 Jul 2013 at 8:16
Attachments:
additional the latest screenshot
Original comment by holger.h...@gmail.com
on 12 Jul 2013 at 8:17
Attachments:
Thanks Holger, great work! I assume the binding contained in the package
corresponds to the latest sources in your repo?
We will schedule the review so that your binding can be part of the next
openHAB 1.3 release.
Original comment by kai.openhab
on 13 Jul 2013 at 1:53
yes. the package corresponds to the latest source in my repo.
Original comment by holger.h...@gmail.com
on 13 Jul 2013 at 1:56
1st Review is done (see your Email)! Thanks for your work, Thomas E.-E.
Original comment by teichsta
on 30 Jul 2013 at 9:33
Hi Holger, any updates? Did you receive my review email? Regards, Thomas E.-E.
Original comment by teichsta
on 5 Aug 2013 at 9:27
Hi Thomas, it's all arrived. I will work through the list tonight! Best, Holger
Original comment by holger.h...@gmail.com
on 6 Aug 2013 at 5:07
ok, would be great if you could report your progress here
Original comment by teichsta
on 6 Aug 2013 at 4:27
changes are done.
Original comment by holger.h...@gmail.com
on 6 Aug 2013 at 7:50
Thanks Holger, will review and merge if applicable. Best, Thomas E.-E.
Original comment by teichsta
on 11 Aug 2013 at 11:06
binding is merged into default branch (see
http://code.google.com/p/openhab/source/detail?r=fc5e07286fcd4a6a2b73893df720035
12e0aa6d3).
It would be cool if you could add a demo-section to the Wiki-Page as done for
the Onkyo-Binding.
Best,
Thomas E.-E.
Original comment by teichsta
on 12 Aug 2013 at 7:12
No problem. I'll do it next days.
Original comment by holger.h...@visual-meta.com
on 12 Aug 2013 at 7:21
with demo-section you mean a wiki page under Features/Bindings/ComfoAir Binding
Original comment by holger.h...@gmail.com
on 13 Aug 2013 at 2:26
No, i meant an abstract within the existing wiki page. See
http://code.google.com/p/openhab/wiki/EpsonProjectorBinding for an example.
Original comment by teichsta
on 13 Aug 2013 at 2:28
is done.
http://code.google.com/p/openhab/wiki/ComfoAirBinding
i would like to add a zip file at the end of the page with my own unchanged
samples. it contains some powerful rules (like the auto_mode) and some
additional String items with combinded item data from different other items.
for details see my screenshot.
Original comment by holger.h...@gmail.com
on 13 Aug 2013 at 3:10
Thanks!
> i would like to add a zip file at the end of the page with my own unchanged
samples.
I would rather opt for adding your examples to the samples and add links vice
versa. What do you think?
Original comment by teichsta
on 13 Aug 2013 at 3:14
that sounds good. but it will be a drop in replacement of my current up to date
configuration and contains many german words inside the configuration.
Original comment by holger.h...@gmail.com
on 13 Aug 2013 at 3:34
can you add me as a committer to the sample wiki.
Original comment by holger.h...@gmail.com
on 13 Aug 2013 at 8:00
sure, done!
Original comment by teichsta
on 13 Aug 2013 at 9:04
Original issue reported on code.google.com by
holger.h...@gmail.com
on 24 Jun 2013 at 7:28Attachments: