KartikTalwar / gmail.js

Gmail JavaScript API
MIT License
3.74k stars 455 forks source link

fix: update code in get.loggedin_accounts() and helper.get.is_delegat… #708

Closed onestep closed 2 years ago

onestep commented 2 years ago

…ed_inbox() to support new Gmail (#707)

josteink commented 2 years ago

Hey there and thanks for the patch.

I’m on vacation now and won’t be able to expedite PRs efficiently nor test changes for at least another week now.

That said, the changes look simple enough, but I think they can be improved with a few small changes:

If you can work with that while I’m on vacation, I can try to take another look when I get back.

onestep commented 2 years ago

Hello, thanks for the comments, I've added additional commit to address them. 🙂 I just wanted to keep existing style and minimize diff as much as possible.

josteink commented 2 years ago

Tested and works fine. Consider it merged!

josteink commented 2 years ago

v1.0.24 out on NPMJs now, with these fixes included :)