search

KartikTalwar / gmail.js

Gmail JavaScript API
MIT License
3.74k stars 455 forks source link

Uncaught TypeError: Cannot read properties of undefined (reading '1') #724

Closed cancan101 closed 1 year ago

cancan101 commented 1 year ago

On let thread_root = json["1"]["1"]; in parse_bv_embedded_json:

    api.tools.parse_bv_embedded_json = function (json) {
        // ensure JSON-format is known and understood?
        // JSON-format is not simple to understand, code here is bases on hypothesis
        let thread_root = json["1"]["1"];
        if (!thread_root || !Array.isArray(thread_root)) {
            return null;
        }
josteink commented 1 year ago

I believe this is fixed in the latest version or any version above 1.1.1.

josteink commented 1 year ago

I hate to be the guy who shrugs this off as "works on my machine", but I currently can't see any runtime-errors in my extension.

Can you still reproduce this?

cancan101 commented 1 year ago

I have not seen this issue since upgrading.