search

KartikTalwar / gmail.js

Gmail JavaScript API
MIT License
3.74k stars 455 forks source link

fix: add reply button selector for text button labels mode (#738) #739

Closed onestep closed 6 months ago

josteink commented 1 year ago

Sorry about the slow response. Work at work, Christmas at home, illness everywhere, etc.

I've just tested this fix and confirm it fixes the original issue without creating any regressions as far as I can see.

If you'd like for me to create a new release for this, feel free to update CHANGELOG.md to include your bugfix too, before I merge :smile:

josteink commented 11 months ago

Old PR is old. Closing.

Re-open and let me know if you still want this added.

onestep commented 6 months ago

Hello, this issue is still valid and we still have a workaround for it in our code (overriding gmail-js function with our own). 🙂 Consider reopening and merging.

josteink commented 6 months ago

I'm open to merging, but I requested specific changes first. See above 🙂

Get those done and we'll get this closed proper.

onestep commented 6 months ago

Updated CHANGELOG.md.

josteink commented 6 months ago

Merged. Thanks!