search

KartikTalwar / gmail.js

Gmail JavaScript API
MIT License
3.75k stars 457 forks source link

fix: Attachment URL parsing #743

Closed obogdanov-entrypoint closed 1 year ago

obogdanov-entrypoint commented 1 year ago

Based on https://github.com/KartikTalwar/gmail.js/issues/742

josteink commented 1 year ago

Hey there and thanks for the PR!

I've tested the use-case myself and can confirm that the bug exists, and that this updated code fixes it.

The code itself looks OK, and from what I can tell the change doesn't break any tests.

If you could also update the changelog, we can merge this, and make a new release.

josteink commented 1 year ago

Thanks. LGTM! Consider it merged!

josteink commented 1 year ago

And published to npmjs too!