BT doesn't offer to use offset temperature compensation despite the TRV having such property

R1DEN commented 1 year ago

Prerequisites

[x] Model name of your Devices TS0601 by _TZE200_b6wax7g0

[x] Output from Home Assistant Device Diagnostic from BT

{
"home_assistant": {
"installation_type": "Home Assistant Supervised",
"version": "2023.8.3",
"dev": false,
"hassio": true,
"virtualenv": false,
"python_version": "3.11.4",
"docker": true,
"arch": "aarch64",
"timezone": "Europe/Chisinau",
"os_name": "Linux",
"os_version": "6.1.21-v8+",
"supervisor": "2023.08.1",
"host_os": "Raspbian GNU/Linux 11 (bullseye)",
"docker_version": "24.0.5",
"chassis": "",
"run_as_root": true
},
"custom_components": {
"healthchecksio": {
  "version": "22.2.0",
  "requirements": [
    "integrationhelper"
  ]
},
"better_thermostat": {
  "version": "1.2.2",
  "requirements": []
},
"hacs": {
  "version": "1.32.1",
  "requirements": [
    "aiogithubapi>=22.10.1"
  ]
},
"ble_monitor": {
  "version": "12.3.2",
  "requirements": [
    "pycryptodomex>=3.14.1",
    "janus>=1.0.0",
    "aioblescan>=0.2.14",
    "btsocket>=0.2.0",
    "pyric>=0.1.6.3"
  ]
},
"ecowater_softener": {
  "version": "3.0.0",
  "requirements": [
    "ecowater-softener==1.0.0"
  ]
},
"dreame_vacuum": {
  "version": "v0.16.4",
  "requirements": [
    "pillow",
    "numpy",
    "pybase64",
    "requests",
    "pycryptodome",
    "python-miio>=0.5.6",
    "py-mini-racer"
  ]
},
"smartthinq_sensors": {
  "version": "0.33.0",
  "requirements": [
    "pycountry>=20.7.3",
    "xmltodict>=0.12.0",
    "charset_normalizer>=2.0.0"
  ]
}
},
"integration_manifest": {
"domain": "better_thermostat",
"name": "Better Thermostat",
"after_dependencies": [
  "climate"
],
"codeowners": [
  "@kartoffeltoby"
],
"config_flow": true,
"dependencies": [
  "climate",
  "recorder"
],
"documentation": "https://github.com/KartoffelToby/better_thermostat",
"iot_class": "local_push",
"issue_tracker": "https://github.com/KartoffelToby/better_thermostat/issues",
"requirements": [],
"version": "1.2.2",
"is_built_in": false
},
"data": {
"info": {
  "name": "Bedroom ",
  "temperature_sensor": "sensor.ble_temperature_5a582d34125e",
  "off_temperature": 20,
  "humidity_sensor": "sensor.ble_humidity_5a582d34125e",
  "weather": "weather.riden_s_home",
  "window_sensors": "binary_sensor.lumi_lumi_sensor_magnet_aq2_opening",
  "outdoor_sensor": null,
  "window_off_delay": 0,
  "model": "TS0601"
},
"thermostat": {
  "climate.bedroom_trv_thermostat": {
    "name": "Bedroom TRV Thermostat",
    "state": "heat",
    "attributes": {
      "hvac_modes": [
        "heat"
      ],
      "min_temp": 5.0,
      "max_temp": 30.0,
      "preset_modes": [
        "none",
        "away",
        "Schedule",
        "eco",
        "boost",
        "Temporary manual"
      ],
      "current_temperature": 24.0,
      "temperature": 5.0,
      "hvac_action": "idle",
      "preset_mode": "none",
      "system_mode": "[<SystemMode.Heat: 4>]/heat",
      "occupancy": 1,
      "occupied_heating_setpoint": 500,
      "friendly_name": "Bedroom TRV Thermostat",
      "supported_features": 17
    },
    "bt_config": {
      "calibration": "target_temp_based",
      "calibration_mode": "fix_calibration",
      "protect_overheating": false,
      "no_off_system_mode": true,
      "heat_auto_swapped": false,
      "child_lock": false,
      "homaticip": false
    },
    "bt_adapter": "zha",
    "bt_integration": "zha",
    "model": "TS0601"
  }
},
"external_temperature_sensor": {
  "entity_id": "sensor.ble_temperature_5a582d34125e",
  "state": "23.71",
  "attributes": {
    "state_class": "measurement",
    "sensor_type": "ATC",
    "mac_address": "5A:58:2D:34:12:5E",
    "last_packet_id": 138,
    "firmware": "ATC (Custom)",
    "uuid": "5A:58:2D:34:12:5E",
    "battery_level": 52,
    "last_mean_of": 1,
    "median": 23.71,
    "mean": 23.71,
    "rssi": -67,
    "unit_of_measurement": "\u00b0C",
    "device_class": "temperature",
    "friendly_name": "Bedroom Temperature"
  },
  "last_changed": "2023-08-22T09:33:39.992604+00:00",
  "last_updated": "2023-08-22T09:33:39.992604+00:00",
  "context": {
    "id": "01H8E9FE8RNDH0MMEXH5KKDK0F",
    "parent_id": null,
    "user_id": null
  }
},
"window_sensor": {
  "entity_id": "binary_sensor.lumi_lumi_sensor_magnet_aq2_opening",
  "state": "off",
  "attributes": {
    "device_class": "opening",
    "friendly_name": "Bedroom Window Opening"
  },
  "last_changed": "2023-08-22T09:21:35.171523+00:00",
  "last_updated": "2023-08-22T09:21:35.171523+00:00",
  "context": {
    "id": "01H8E8SAE3MMMASEHN2X13X4ZS",
    "parent_id": null,
    "user_id": null
  }
}
}
}

Description

BT doesn't allow offset compensation

Steps to Reproduce

Try to add a new BT integration

Expected behavior:

BT has the option to compensate with offset as my TRV has the offset property

Actual behavior:

BT doesn't allow offset compensation

Versions

HA 2023.8.3 BT 1.2.2

Additional Information

wtom commented 1 year ago

when i have time, i will implement this.

wtom commented 1 year ago

the problem here is, to find the right entity. yours is called bedroom_trv_number_temperature_calibration and for my TRV for example it's number.heizung_badezimmer_number_temperature_offset.

@KartoffelToby wrote it here in the comments, hacky way. https://github.com/KartoffelToby/better_thermostat/blob/master/custom_components/better_thermostat/utils/helpers.py#L527:L566

We would now need to add our cases, and then more and more. In the future. But the Temperature based calibration should also work, so i think this is not a prio?

wtom commented 1 year ago

we would then also need to add some code to the adapters. like it is in the mqtt adapter. all the offset related code.

maybe i will try it tomorrow and test it with one of my thermostats.

R1DEN commented 1 year ago

Are there any drawbacks with replacing that with a more generic

'temperature_calibration' in uid
||
'temperature_offset' in uid

?

P.S. Sorry, posted it from wrong account. reposting so that the history is not lost)

wtom commented 1 year ago

I've made a PR.

KartoffelToby / better_thermostat