search

KartoffelToby / better_thermostat

This custom component for Home Assistant will add crucial features to your climate-controlling TRV (Thermostatic Radiator Valves) to save you the work of creating automations to make it smart. It combines a room-temperature sensor, window/door sensors, weather forecasts, or an ambient temperature probe to decide when it should call for heat and automatically calibrate your TRVs to fix the imprecise measurements taken in the radiator's vicinity.
https://better-thermostat.org
GNU Affero General Public License v3.0
759 stars 121 forks source link

Allow to change the real thermostat (climate entity) #1283

Open janvda opened 7 months ago

janvda commented 7 months ago

What is the feature?

Using the configure window you can change most thermostat settings but you can't change the real thermostat (climate entity). Here below a screenshot of the configure window:

image

So it would be nice to add also the possibility to change the real thermostat as you can do when creating a new better thermostat device (see screenshot below)

image

wtom commented 7 months ago

1087

janvda commented 7 months ago

closed as it is indeed a duplicate of https://github.com/KartoffelToby/better_thermostat/discussions/1087

janvda commented 7 months ago

reopened as https://github.com/KartoffelToby/better_thermostat/discussions/1087 is not a ticket but a discussion.

countrr commented 7 months ago

Yes, this featuture (or bugfix?) would be great! What I today discovered: I have two TRVs from different brands, one needs the auto/heat swapped, the other not. Setting this separately is currently not possible when combined in one BT. I guess this may be closely related to this feature?

KartoffelToby commented 7 months ago

The thing is, the entity is the heart of the configuration. If it changes, you can create a new one straight away.

Its not a bug. It how the config flow works

bassie1995 commented 7 months ago

@KartoffelToby What would you think of adding some text in the initial and edit dialogs? I think there could be some room for a short explanation, even if just to say "you cannot edit this later."

I can make a PR for it, shouldn't be too difficult :)

countrr commented 7 months ago

Understood, it’s just a pity that any surrounding automations also need to be updated, as the new BT will have a different name. But obviously this is not a life threatening problem :) About the swapping of auto/heat: could that be made separate for each TRV?

KartoffelToby commented 7 months ago

@bassie1995 It's also easy to add the option for replacing the entity, but as I said, the question is what's the point if a completely new TVR can be created using the options anyway?

But if it's what many people want, I won't stand in the way. Feel free to make a PR :)

KartoffelToby commented 7 months ago

@countrr yes, that is possible, I would be surprised if it wasn't already queried for each individual?

countrr commented 7 months ago

@countrr yes, that is possible, I would be surprised if it wasn't already queried for each individual?

Sorry, yes, you are right, it can be set separately. I had not recognized that the same setting screen appears twice. I did not recognize the device ID shown in the top, as it is not the friendly name.

wtom commented 7 months ago

Understood, it’s just a pity that any surrounding automations also need to be updated, as the new BT will have a different name. But obviously this is not a life threatening problem :)

If you set the same name as before, then BT will have the same name and the automations should work fine. I didn't it a couple of times. Also scheduler card works after recreation of the BT integration normally.