Local temperatur calibration being completly wrong

[LarsK1]

Prerequisites

• [x] Model name of your Devices: Tuya TS0601

Unfortunately I can't generate diagnostic data (see #1469)

Description

Somehow the local temperature calibration is way of. See these images. The temperature sensor reads 22.2°C, the thermostat it self reports 21.5°C, which should result in an offset of 0.7°C, but it is set to 9°C?

Device config:

Versions

BT: 1.7.0-beta1 HA: 2024.11.1

[eflye]

my 20 cents, i'm digging within the same kind of issue. I was able to identify that calibration is impacted by the following code change from the beta in calibration.py:

    # Base calibration adjustment considering tolerance
    if _cur_external_temp >= _cur_target_temp + self.tolerance:
        _new_trv_calibration += (
            _cur_external_temp - (_cur_target_temp + self.tolerance)
        ) * 2.0

https://github.com/KartoffelToby/better_thermostat/blob/1641f4a19f91bd8abdc465dbf6533a86d663ae9a/custom_components/better_thermostat/calibration.py#L114

@KartoffelToby may i ask you to explain why _new_trv_calibration is changed when _cur_external_temp > _cur_target_temp. Example here:

Before quoted if statement, new_trv_calculation = 0 ( after respecting tolerance in all calibration modes, delaying heat is statement)

• _cur_external_temp -> 17.7
• _cur_target_temp -> 17.0
• self.tolerance -> 0.0
• Result -> _new_trv_calibration after base calibration adjustement considering tolrance -> 1.3999999999999986

It's impact Normal mode also.

I'm going to rollback to previous version and i will follow explanation.

Let me know if both case are not the same and if i have to create another issue.

[LarsK1]

@eflye try changing this line (https://github.com/KartoffelToby/better_thermostat/blob/1641f4a19f91bd8abdc465dbf6533a86d663ae9a/custom_components/better_thermostat/calibration.py#L195) to this: _new_trv_calibration = _cur_external_temp - (_cur_trv_temp_f - _current_trv_calibration)

[LarsK1]

That's resolved the issue for me.