KartulUdus / PoracleJS

NodeJS application for PokémonGo WebHook Discord alarms
https://kartuludus.github.io/PoracleJS/#/
ISC License
96 stars 115 forks source link

stickerUrl in default.json #494

Closed Fabio1988 closed 3 years ago

Fabio1988 commented 3 years ago

https://github.com/whitewillem/PogoAssets does not have folder structure like it's mentioned in default.json following error will happen in logs Failed to send Telegram sticker https://raw.githubusercontent.com/whitewillem/PogoAssets/resized/icons_large/telegram/pokemon_icon_554_2063.webp

Expected Behavior

sticker should be send within DTS in telegram?!

Current Behavior

error in logs

Possible Solution

Steps to Reproduce (for bugs)

  1. use default dts for telegram
  2. use stickerUrl from default.json
  3. track some pokemon in telegram
  4. wait until pokemon message will appear
  5. search in logs for error

Context

Your Environment

jfberry commented 3 years ago

I know it's not a complete repository but it's the best I am aware of which I have permission to include as a default. There are some privately created repositories - perhaps ask on discord?

Good news may be at hand though, because with the new icon naming format (uicons) some of the main repositories may create a webp equivelant

jfberry commented 3 years ago

Since I wrote that a UICONS repository for telegram has become available The UICONS pull request has that as default now feel free to test it!

Fabio1988 commented 3 years ago

I know it's not a complete repository but it's the best I am aware of which I have permission to include as a default. There are some privately created repositories - perhaps ask on discord?

Good news may be at hand though, because with the new icon naming format (uicons) some of the main repositories may create a webp equivelant

But path resized/icons_large/telegram/ does not exist anymore in that repo 😅 it's StickerURL, not imgUrl :)

Thx for uicons PR, will have a try.

jfberry commented 3 years ago

Resolved in uicons now in master and develop