Make static maps memes for april fools - Githubissues

KartulUdus / PoracleJS

NodeJS application for PokémonGo WebHook Discord alarms

https://kartuludus.github.io/PoracleJS/#/

ISC License

96 stars 115 forks source link

Make static maps memes for april fools #835

Open auisgold opened 1 year ago

auisgold commented 1 year ago

Description

Make memes for April Fools, DUH, PEEPO

Motivation and Context

Who doesn't love a good april fools joke?

How Has This Been Tested?

April fools test however DA EF YOU WAN jk, static map provider is meme in config

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ X ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ X ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

jfberry commented 1 year ago

Biggest issue with this PR for me is that in all cases at all times of year the meme endpoint will be called for every alert whether you care about it or not.