search

KartulUdus / PoracleJS

NodeJS application for PokémonGo WebHook Discord alarms
https://kartuludus.github.io/PoracleJS/#/
ISC License
96 stars 115 forks source link

Fix raid/egg Everything Command #842

Closed Kneckter closed 1 year ago

Kneckter commented 1 year ago

The last code change in #839 added a + to the everything command, which made it stop at level 9. This fix allows the command to track the whole array of raid levels.

jfberry commented 1 year ago

Did you check this? It works fine for me before. The + means 'convert to integer' in javascript.

Kneckter commented 1 year ago

I did test it, I wasn't just reading code for the fun of it lol

Before Screenshot_20230526-134733_Discord

After Screenshot_20230526-134757_Discord

jfberry commented 1 year ago

Before:

image

I'm not sure why you would have a problem...

Kneckter commented 1 year ago

I'm not sure but it did check the first 9. Maybe there is a different issue buy this worked

TurtIeSocks commented 1 year ago

Could this be an issue related to editing existing tracks? In the first screenshot you aren't removing them first and each one says "unchanged"

Kneckter commented 1 year ago

That is what I was thinking as an alternative issue. I'm just not home yet to recheck.

Kneckter commented 1 year ago

I'm not sure what caused it but I'm closing this if it's not needed.

jfberry commented 1 year ago

I wouldn't want you to close it if there is genuinely a problem, but I am not sure it is the one you thought it was. I need to rework these functions anyway as I notice that they incorrectly imported values that are passed as context but it won't change the sematics