KartulUdus / PoracleJS

NodeJS application for PokémonGo WebHook Discord alarms
https://kartuludus.github.io/PoracleJS/#/
ISC License
96 stars 115 forks source link

fix: fort update webhook #870

Closed TurtIeSocks closed 1 year ago

TurtIeSocks commented 1 year ago

Description

Motivation and Context

Valid time and fix c&p bugs

How Has This Been Tested?

Currently untested

Screenshots (if appropriate):

Types of changes

Checklist:

ReuschelCGN commented 1 year ago

https://github.com/TurtIeSocks/PoracleJS/blob/f07c85725db0645ca78b9aed8592e6dc756cc14e/src/controllers/fortupdate.js#L208

think this could also be remove

ReuschelCGN commented 1 year ago

removing Line: 100 & 99 makes probs with Lines: 255-258

jfberry commented 1 year ago

Removing tth will cause the senders to fail if clean specified at very least

Fabio1988 commented 1 year ago

Should we even allow to clean those hooks? Imo this does not make sense, right?

jfberry commented 1 year ago

Should we even allow to clean those hooks? Imo this does not make sense, right?

Even if you don't allow clean in the track command the tth values need to be there for the sending code not to crash

TurtIeSocks commented 1 year ago

Made a neat mess of git history. Please squash and merge when it's time to do so 😂