a little Poracle spring update

[ReuschelCGN]

• update Readme, node version 20 recommended
• update several packages (tested prod.)
• switch node-fetch package to node-fetch-native for better backward and forward compatibility
• add golbat support to scanner type with own db lookup file for forward compatibility
• cleanup german translation (remove unused quests translation keys)
• add lineup invasion hook processing for golbat system (activate with new configkey) -- gruntLineupList.monsters.id -- gruntLineupList.monsters.formId -- gruntLineupList.monsters.name -- gruntLineupList.monsters.formName -- gruntLineupList.monsters.fullName e.G. use it in DTS like this: {{#if (lt gruntTypeId '100')}}Lineup: {{#forEach gruntLineupList.monsters}}{{this.fullName}}{{#unless isLast}}, {{/unless}}{{/forEach}}\n{{/if}}
• add new configkey to deactivate invasion hooks without lineups (prevents duplicate invasion messages - one without and after, one with lineup (reduces messages in discord) BUT then, you will only get the invasion message for stops in your mon scanning area -> with lineups)
• add lineup testdata !poracle-test pokestop lineup
• fix showcase message delete (clean) in webhook channels
• fix some vars in poracleMessage/commands/
• add more fort_update testdata to cover all cases

[kamieniarz]

Would it be possible to also add hook that could display reward(s)?

[kamieniarz]

@ReuschelCGN looks like "disableNotConfirmedInvasion": true fully turns off kecleon, goldstop and showcases alerts 😬

[kamieniarz]

Also something is broken with reactmap's poracle integration. When I open webhook management my gym and raid tabs are empty and also when I try to add gym tracking from map I'm getting poracle error:

2024-03-30 17:30:10 $MAIN error: API: 127.0.0.1 POST /api/tracking/gym/:id scannerQuery.getGymName is not a function {
  stack: 'TypeError: scannerQuery.getGymName is not a function\n' +
    '    at Object.gymRowText (/home/toaster/PoracleJS/src/lib/PoracleJSMessage/commands/tracked.js:82:66)\n' +
    '    at Object.<anonymous> (/home/toaster/PoracleJS/src/routes/apiTrackingGym.js:149:83)\n' +
    '    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)',
  [Symbol(level)]: 'error',
  [Symbol(splat)]: [
    TypeError: scannerQuery.getGymName is not a function
        at Object.gymRowText (/home/toaster/PoracleJS/src/lib/PoracleJSMessage/commands/tracked.js:82:66)
        at Object.<anonymous> (/home/toaster/PoracleJS/src/routes/apiTrackingGym.js:149:83)
        at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
  ],
  [Symbol(message)]: '{"level":"error","message":"API: 127.0.0.1 POST /api/tracking/gym/:id scannerQuery.getGymName is not a function","stack":"TypeError: scannerQuery.getGymName is not a function\\n    at Object.gymRowText (/home/toaster/PoracleJS/src/lib/PoracleJSMessage/commands/tracked.js:82:66)\\n    at Object.<anonymous> (/home/toaster/PoracleJS/src/routes/apiTrackingGym.js:149:83)\\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"}'
}

EDIT: looks like there's an issue with "scannerType" - I changet that from rdm to golbat and it broke

[ReuschelCGN]

broken reactmap's poracle integration should be fixed

[ReuschelCGN]

looks like "disableNotConfirmedInvasion": true fully turns off kecleon, goldstop and showcases alerts 😬

should be fixed now, sorry for that

[Fabio1988]

Thanks a lot for that update :)

@jfberry you think it would be time to introduce some new webhook types? Different ones for Incident (kecleon, showcase) and invasion... A new one for confirmed lineups? Therefore we would prevent additional configs and blocking of webhooks

[jfberry]

Thanks a lot for that update :)

@jfberry you think it would be time to introduce some new webhook types? Different ones for Incident (kecleon, showcase) and invasion... A new one for confirmed lineups? Therefore we would prevent additional configs and blocking of webhooks

You'd still want these configs. Webhooks should not be blocked on the golbat side. Open to changes but not sure what you imagine would be different in terms of flow?

[Fabio1988]

Thanks a lot for that update :) @jfberry you think it would be time to introduce some new webhook types? Different ones for Incident (kecleon, showcase) and invasion... A new one for confirmed lineups? Therefore we would prevent additional configs and blocking of webhooks

You'd still want these configs. Webhooks should not be blocked on the golbat side. Open to changes but not sure what you imagine would be different in terms of flow?

True config is still needed for the flow. I won't block in golbat as well... But it's kinda weird that this PR won't send hooks to discord for fort only areas anymore.

[jfberry]

Thanks a lot for that update :) @jfberry you think it would be time to introduce some new webhook types? Different ones for Incident (kecleon, showcase) and invasion... A new one for confirmed lineups? Therefore we would prevent additional configs and blocking of webhooks

You'd still want these configs. Webhooks should not be blocked on the golbat side. Open to changes but not sure what you imagine would be different in terms of flow?

True config is still needed for the flow. I won't block in golbat as well... But it's kinda weird that this PR won't send hooks to discord for fort only areas anymore.

Thats a problem with the implementation rather than the hooks though - it's a good point which may require some further consideration

[jfberry]

Are you going to address the config titles so we can get this merged?

[jfberry]

Ready to merge? I'm not sure the issue of non-lineup invasion types is resolved?