search

Karumi / Dexter

Android library that simplifies the process of requesting permissions at runtime.
http://karumi.com
Apache License 2.0
5.23k stars 670 forks source link

Add force permission option #147

Closed bastienpaulfr closed 7 years ago

bastienpaulfr commented 7 years ago

Hi

I have added a "force" option to ask for permission even if the system tells that the permission is granted.

I have the need of this option because I am developing a system app. Android is telling me that I got the permission whereas I still need to ask for explicitly.

You have made a great job ! Tks

pedrovgs commented 7 years ago

Hi @bastienpaulfr

Could you provide some documentation about the scenario you mention in the PR description?

I have the need of this option because I am developing a system app. Android is telling me that I got the permission whereas I still need to ask for explicitly.

I'd like to know more about this feature before to merge this PR.

bastienpaulfr commented 7 years ago

Hi @pedrovgs

I prefer adding a force option than checking that the app is system app. May be on some devices the original logic is working without my changes. Then the force option would be not necessary.

I will provide some documentation about this request and submit it again. I will also divide all my requests to make things cleaner. Thank you for the review.

bastienpaulfr commented 7 years ago

I will close this pull request to make new ones from separate branches