search

Karumi / Dexter

Android library that simplifies the process of requesting permissions at runtime.
http://karumi.com
Apache License 2.0
5.23k stars 671 forks source link

fix memory leak #186

Closed lzdon closed 6 years ago

lzdon commented 6 years ago

i found there is memory leak when permissions are granted. i read the code , found that the field 'listener' not released ,is there some sepcial reason?

untalfranfernandez commented 6 years ago

Hi @lzdon , Travis CI is failing for your PR. Before accepting any change we need that check to be passed.

autonomousapps commented 6 years ago

Could we get some movement on this? The memory leak is real.

autonomousapps commented 6 years ago

https://github.com/Karumi/Dexter/issues/197

Serchinastico commented 6 years ago

Hi @autonomousapps

Please, refer to https://github.com/Karumi/Dexter#do-you-want-to-contribute We need PRs to be validated by Travis before merging anything into master

autonomousapps commented 6 years ago

Yup, I totally get it. I guess I was hoping the original contributor would take another stab at it. I'm honestly not even sure his PR fixes the problem... looks a bit like a stab in the dark, but I guess it might work :man_shrugging: