search

Karumi / Dexter

Android library that simplifies the process of requesting permissions at runtime.
http://karumi.com
Apache License 2.0
5.23k stars 671 forks source link

Update Gradle build to target SDK 26 in reference to issue #177 #187

Closed dan-0 closed 6 years ago

dan-0 commented 6 years ago

Build test was successful, unfortunately the minSdkVersion in the core dexter module had to be raised to 14 from 10 to be compatible with newer versions of Gradle, but the impact should be minimal.

dan-0 commented 6 years ago

This is only failing build test because:

> Failed to notify project evaluation listener.
   > You have not accepted the license agreements of the following SDK components:
     [Android SDK Platform 26, Android SDK Build-Tools 26.0.2].
     Before building your project, you need to accept the license agreements and complete the installation of the missing
Camerash commented 6 years ago

Try following the workaround in https://stackoverflow.com/a/42736695 in .travis.yml ?

Camerash commented 6 years ago

Also maybe it is better to update the gradle plugin to 3.0.1 as the version in the pr is in beta and outdated :see_no_evil:

Serchinastico commented 6 years ago

This is outdated with #208

Sorry it took so long for us to review it 🙏 . Thank you very much for your contribution though.