search

Karumi / Dexter

Android library that simplifies the process of requesting permissions at runtime.
http://karumi.com
Apache License 2.0
5.23k stars 671 forks source link

permission declaration inside the application tag does not send any notification as that does not allow app to request the required permissions. #195

Closed RbkGh closed 6 years ago

RbkGh commented 6 years ago

Expected behaviour

There should be a notification when the permission is declared inside application tag in the manifest file or the docs should be updated to ensure that users of the library do not forget to declare the permissions outside the application tag in the manifest file.

Actual behaviour

The request for the permission simply does not show up and the permission is not granted.

Steps to reproduce

Version of the library

untalfranfernandez commented 6 years ago

Hi @RbkGh, thanks for your request but Dexter's purpose is to handle all the boiler plate related to the permission handling so you can focus in your app business logic.

If you declare your permissions outside the application tag, Dexter will behave as the system, so that's not an issue.

Once said that, if you have a PR that solves the problem you've described, I encourage you to submit it so we can review it and discuss about it.

RbkGh commented 6 years ago

196 this pull request should enhance this