Fix token bypassed in base listeners

Karumi / Dexter

Android library that simplifies the process of requesting permissions at runtime.

http://karumi.com

Apache License 2.0

5.23k stars 671 forks source link

Fix token bypassed in base listeners #205

Closed Camerash closed 6 years ago

Camerash commented 6 years ago

What's in this PR?

Fixes Karumi#184
- Permission token control now only depends on onPermissionRationaleShouldBeShown function in PermissionListener / MultiplePermissionsListener

Camerash commented 6 years ago

I have considered adding a bypassRationale flag in builders of the listeners to decide whether or not to consume the token in the respective listener, since people seems to forget consuming the token and lead to permission granting came to a halt. Don't know if it is better this way though :thinking:

Serchinastico commented 6 years ago

Hi @Camerash, we can't really apply these changes to fix #184. The issue is in the sample project, not the base listeners implementation, we can't change that without breaking backwards compatibility and there is a strong reason we are calling the token in the base listeners, that is, we had a lot of reports of people not understanding they had to call the token to continue the process.

Thank you for your contribution, though