Closed dzboot02 closed 4 years ago
Hi @hiddeneyes02
I see, we are directly associating !ActivityCompat.shouldShowRequestPermissionRationale(activity, permission)
to the isPermanentlyDenied
flag but as you said, before API 23, it doesn't make much sense and should be false instead. We should be adding that the isPermanentlyDenied
method to AndroidPermissionService
and check for the Android version there.
I'm sending a PR to fix this issue.
Expected behaviour
When user denies multiple times a permission on Android6.0, he can't use Never ask again checkbox, because it does not exist yet on API23. So using
isPermanentlyDenied()
has no sense on this API.Actual behaviour
PermissionDeniedResponse.isPermanentlyDenied()
always trueSteps to reproduce
This code works fine on API 27, but when executed on API 23 it never gets to
//all permissions are denied
partVersion of the library
I am using this
implementation 'com.karumi:dexter:5.0.0'
It would be right to return false in this case to avoid some extra complicated code. And also because will be always represented with the system's Grant Deny dialog if the feature is requested again from the app.
Thank you.