fix #262 - Githubissues

Karumi / Dexter

Android library that simplifies the process of requesting permissions at runtime.

http://karumi.com

Apache License 2.0

5.23k stars 671 forks source link

fix #262 #264

Closed binarynoise closed 4 years ago

binarynoise commented 4 years ago

:pushpin: References

Issue: #262

:tophat: What is the goal?

Fix permission listener not called after starting new dialog

:memo: How is it being implemented?

see https://github.com/Karumi/Dexter/issues/262#issuecomment-653900308

:robot: How can it be tested?

[ ] Use case 1: Start new Dialog from within the permission listener
[ ] Use case 2: Start new Dialog when Animations triggered by previous permission listener are still going on (and thus the main thread is busy)

pedrovgs commented 4 years ago

Hi @binarynoise this fix is just perfect. I'd love to see some automated tests but I guess it is ok for now in order to fix this bug. I'm merging it and releasing a new version so the user who reported the original bug can check if it is working for them. Thank you so much for your contribution.