search

Karumi / Rosie

Rosie is an Android framework to create applications following the principles of Clean Architecture.
Other
1.82k stars 157 forks source link

Moving Butter Knife and Renderers libraries from Rosie to the sample project, updated sample butterknife version 7.0.1 -> 8.0.1 #68

Closed luis-ibanez closed 8 years ago

luis-ibanez commented 8 years ago

There was a warning for using a @Nullable over a @OnClick method in MarvelActivity.java, I have updated Butterknife, replace that @Nullable for @Optional and updated all the @Bind annotation for @BindView. Fix #70

pedrovgs commented 8 years ago

Thank you so much @luis-ibanez 👍

Serchinastico commented 8 years ago

Awesome PR :+1:

luis-ibanez commented 8 years ago

I'm researching why the tests failed, it seems there is a problem finding the loading view inside the include. Will commit when fixed.

Serchinastico commented 8 years ago

Yup, we got to the same point. Butterknife doesn't bind the views correctly. Thanks for taking a look, we will wait for your update!

luis-ibanez commented 8 years ago

Fixes #70

pedrovgs commented 8 years ago

@luis-ibanez you have some checkstyle violations:

/home/travis/build/Karumi/Rosie/sample/src/main/java/com/karumi/rosie/sample/base/view/fragment/MarvelFragment.java:20:8: Unused import - android.support.annotation.Nullable.
luis-ibanez commented 8 years ago

@pedrovgs the build failed again

pedrovgs commented 8 years ago

Sorry, I'm restarting it again..the problem is the Android Emulator and the Travis-CI environments :S

pedrovgs commented 8 years ago

I've no idea about what's going on with this build :S We always get a timeout during the dexing stage... :_(

luis-ibanez commented 8 years ago

I close this PR just to response better to the #70 issue, and make the update in a separate PR given the problems making everything together is causing.

pedrovgs commented 8 years ago

ok