Update gradle - Githubissues

Karumi / Rosie

Rosie is an Android framework to create applications following the principles of Clean Architecture.

Other

1.82k stars 157 forks source link

Update gradle #97

Open Aracem opened 6 years ago

Aracem commented 6 years ago

:tophat: What is the goal?

Update Gradle (tools, wrapper..) to improve the compilation time and take advantage of the last improvements in Android Studio 3.0. Also, update dependencies to follow new implementation/api instead of compile standard, that helps to improve compilation times

How is it being implemented?

Follow this tutorial https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration?utm_source=android-studio#new_configurations
Add google() repository
Set compile version and target version to 27
Create variables in gradle to update the versions of the library and the samples at the same time

GIF

happy

Aracem commented 6 years ago

Should be updated: https://github.com/Karumi/Rosie/pull/97/files#diff-fd9d61e37d939c941e7a62077f38d62dR22

I have to add a modification to make the CI accept the new Terms And Conditions when updating it. Let me ask a friend of mine about it

pedrovgs commented 6 years ago

You are absolutely right @Aracem the wrapper is updated. I didn't see the file, my bad. We will wait until the build passes to merge this branch. Thank you so much 😃

Aracem commented 6 years ago

The builds are broken due the com.android.library plugin, that download dependencies but Google adds a "accepts terms and conditions" question while downloading, so you have to configure CI to accept it.

Here is the solution: https://stackoverflow.com/a/45782695/628447 yes | sdkmanager --licenses

Aracem commented 6 years ago

Please @pedrovgs review commit and commit before approving the PR. I had to introduce these changes due Checkstyle errors

I need help to resolve the Robolectric error. Let's see how we can resolve it